Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused Restic related stuff. #2418

Merged
merged 2 commits into from
Oct 26, 2023
Merged

Remove unused Restic related stuff. #2418

merged 2 commits into from
Oct 26, 2023

Conversation

e-sumin
Copy link
Contributor

@e-sumin e-sumin commented Oct 20, 2023

Change Overview

We are going to deprecate Restic. This PR removes unused functions from restic.go

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • fixes #issue-number

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@infraq infraq added this to In Progress in Kanister Oct 20, 2023
PrasadG193
PrasadG193 approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@PrasadG193 PrasadG193 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - as long as they are not being used anywhere in the codebase

Kanister automation moved this from In Progress to Reviewer approved Oct 20, 2023
@e-sumin e-sumin added the kueue label Oct 26, 2023
@mergify mergify bot merged commit 1003ad9 into master Oct 26, 2023
14 checks passed
Kanister automation moved this from Reviewer approved to Done Oct 26, 2023
@mergify mergify bot deleted the cleanup-restic-stuff branch October 26, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavannd1 pavannd1 pavannd1 approved these changes

@PrasadG193 PrasadG193 PrasadG193 approved these changes

@viveksinghggits viveksinghggits Awaiting requested review from viveksinghggits

Assignees
No one assigned
Labels
kueue
Projects
Kanister
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@e-sumin @pavannd1 @PrasadG193