Fix CVE because of golang.org/x/net in kanister-tools image
#2419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the kanister's deps were using older version of `x/net` package which resulted into some of the vuln. being reported in the image. This commit makes sure that we are using 0.17.0 version of `x/net`.
While building the tools image, we were also building and packaging `restic` and `kopia` with it. Some of the direct/indirect deps of these projects had a vuln. because of package `x/net`. This commit updates the `go.mod` of these packages while building them to make sure that we are using updated version `0.17.0` of that dep.
viveksinghggits
requested review from
denisvmedia,
pavannd1,
r4rajat and
pchistikov
pchistikov
approved these changes
Oct 20, 2023
kale-amruta
pushed a commit
that referenced
this pull request
Oct 23, 2023
* Add `golang.org/x/net` in replace to make sure we use `v0.17.0` version Some of the kanister's deps were using older version of `x/net` package which resulted into some of the vuln. being reported in the image. This commit makes sure that we are using 0.17.0 version of `x/net`. * Use `0.17.0` version of `golang.org/x/net` in restic and kopia While building the tools image, we were also building and packaging `restic` and `kopia` with it. Some of the direct/indirect deps of these projects had a vuln. because of package `x/net`. This commit updates the `go.mod` of these packages while building them to make sure that we are using updated version `0.17.0` of that dep. * Run go mod tidy and then commit changes
kale-amruta
pushed a commit
that referenced
this pull request
Oct 24, 2023
* Add `golang.org/x/net` in replace to make sure we use `v0.17.0` version Some of the kanister's deps were using older version of `x/net` package which resulted into some of the vuln. being reported in the image. This commit makes sure that we are using 0.17.0 version of `x/net`. * Use `0.17.0` version of `golang.org/x/net` in restic and kopia While building the tools image, we were also building and packaging `restic` and `kopia` with it. Some of the direct/indirect deps of these projects had a vuln. because of package `x/net`. This commit updates the `go.mod` of these packages while building them to make sure that we are using updated version `0.17.0` of that dep. * Run go mod tidy and then commit changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
There were some vulnerabilities reported in kanister-tools image that were because of older version of
golang.org/x/netbeing used in kanister.This PR make sure that we are using latest version of
golang.org/x.netfor kansiter and it's indirect deps as well as the binaries that we build with kanister, i.e., restic and kopia.Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan
Build the kanister-tools image and run grype to make sure no vulns. are reported