Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor kopia maintenance owner helper #2428

Merged
merged 3 commits into from
Oct 24, 2023
Merged

Refactor kopia maintenance owner helper #2428

merged 3 commits into from
Oct 24, 2023

Conversation

pavannd1
Copy link
Contributor

Change Overview

  • Update the helper to use PodController and CommandExecutor
  • Update the test
  • Update go.mod and go.sum

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • fixes #issue-number

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@infraq infraq added this to In Progress in Kanister Oct 24, 2023
ankitjain235
ankitjain235 approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@ankitjain235 ankitjain235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Kanister automation moved this from In Progress to Reviewer approved Oct 24, 2023
@pavannd1 pavannd1 added the kueue label Oct 24, 2023
@mergify mergify bot merged commit 02af7b0 into master Oct 24, 2023
15 checks passed
Kanister automation moved this from Reviewer approved to Done Oct 24, 2023
@mergify mergify bot deleted the main-own branch October 24, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankitjain235 ankitjain235 ankitjain235 approved these changes

@redgoat650 redgoat650 Awaiting requested review from redgoat650

Assignees
No one assigned
Labels
kueue
Projects
Kanister
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pavannd1 @ankitjain235