-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RepositorySetParametersCommand #2429
Conversation
…d-RepositorySetParametersCommand
@@ -34,6 +34,9 @@ type RepositoryCommandArgs struct { | |||
Username string | |||
RepoPathPrefix string | |||
ReadOnly bool | |||
// Only for CreateCommand |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what happens if someone provides this flag with non create command?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fields are not used in RepositoryConnectCommand. The same way PITFlag
is used in Connect but not in Create
@KastenMike can you please share how things look with new subcommand and any test plan. It would be easier to approve the PR. |
What do you mean? There are unit tests in the PR The changes are based on |
e.g.
|
Co-authored-by: Pavan Navarathna <6504783+pavannd1@users.noreply.github.com>
It's a command missing from
command/repository.go
. Added an initial start with the retention settings.Also added related params to the create repository https://kopia.io/docs/reference/command-line/common/repository-create-azure/