Fix the way action set name was being configured #2430
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
Fixes: #2285
kanctl
was able to configure the actionset name using the flag calledaction-set
.But it had two problems
--name
instead of--action-set
. Because there is another flag calledaction
, so it gets confusing between--action-set
and--action
. This PR renames the flag to provide the actionset name to--name
.--name
the actionset would be named exactly that. But the problem was we were usinggenerateName
in code that resulted in a string being added in the name. This PR makes sure that if--name
is provided, the actionset would have exactly this name.Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan