Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example demonstrating Kanister integration with MySQL #244

Merged
merged 2 commits into from
Nov 11, 2019

Conversation

PrasadG193
Copy link
Contributor

Change Overview

This PR is related to: #218
Move stable mysql example to examples/stable/mysql

Pull request type

Please check the type of change your PR introduces:

  • Work in Progress
  • Refactoring (no functional changes, no api changes)
  • Trival/Minor
  • Bugfix
  • Feature
  • Documentation

Issues

  • #XXX

Test Plan

  • Manual
  • Unit test
  • E2E

@PrasadG193 PrasadG193 force-pushed the move-mysql-example branch 4 times, most recently from 1c0f11a to 5dfff5a Compare September 3, 2019 14:09
@PrasadG193 PrasadG193 force-pushed the move-mysql-example branch 2 times, most recently from e588fc3 to fbc6187 Compare September 4, 2019 12:07
Copy link
Contributor

@tdmanv tdmanv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! A few minor comments

examples/stable/mysql/README.md Outdated Show resolved Hide resolved
@@ -0,0 +1,73 @@
apiVersion: cr.kanister.io/v1alpha1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove kanister from the path.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tdmanv I didn't get you. If we remove kanister from apiVersion, it will not work.

examples/stable/mysql/README.md Outdated Show resolved Hide resolved
examples/stable/mysql/README.md Outdated Show resolved Hide resolved
examples/stable/mysql/README.md Show resolved Hide resolved
examples/stable/mysql/README.md Outdated Show resolved Hide resolved
examples/stable/mysql/README.md Outdated Show resolved Hide resolved
examples/stable/mysql/kanister/mysql-blueprint.yaml Outdated Show resolved Hide resolved
Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
@mergify mergify bot merged commit 73db522 into kanisterio:master Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants