Do not apply kopia retention policy on kando location push
#2442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankitjain235
approved these changes
Oct 27, 2023
julio-lopez
reviewed
Nov 3, 2023
Comment on lines
+71
to
+74
| // _, err = policy.ApplyRetentionPolicy(ctx, rep, sourceInfo, true) | ||
| // if err != nil { | ||
| // return "", 0, errors.Wrap(err, "Failed to apply kopia retention policy") | ||
| // } |
There was a problem hiding this comment.
Should commented code be removed, and instead be replaced with a description?
Not sure whether issue #2441 already has a link to this PR / commit. If not, this comment should create the link anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
403error.kandolocation push #2441 for tracking.Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan