Set soft limit for content cache while connecting to server in kopia client options #2449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amruta Kale <amruta.kale@veeam.com>
pavannd1
changed the title
|
@julio-lopez Could you please take a look at kopia upstream and confirm if it's a bug or intentionally done? |
pavannd1
approved these changes
Oct 30, 2023
pavannd1
reviewed
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
Currently while connecting to kopia server using client we are setting only hard limits in the connectOptions . But this kopia function which is called while connecting to server has the logic of setting caching as specified here. It checks if the soft limit for contenct cache is set. If it is not set, caching options are not initalized and is returned as empty struct. Hence hard limits for cache can never be set while connecting to server. This makes it compulsory to set soft limit for the content cache while connecting to server
This PR sets soft limit of content cache(It uses same value as hard value)
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan