Always populate TemplateParams 'Object' #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdmanv
approved these changes
Aug 28, 2019
| //return cli.Resource(resource).Namespace(namespace).List(metav1.ListOptions{}) | ||
| return cli.Resource(resource).List(metav1.ListOptions{}) | ||
| // ListUnstructuredObjectWithCli returns the referenced API objects as a map[string]interface{} using the specified CLI | ||
| // TODO: deprecate `ListUnstructuredObject` |
pkg/param/param_test.go
Outdated
| @@ -543,6 +564,9 @@ func (s *ParamsSuite) TestPhaseParams(c *C) { | |||
| c.Assert(err, IsNil) | |||
|
|
|||
| crCli := crfake.NewSimpleClientset() | |||
There was a problem hiding this comment.
[nit] Create this closer to its use.
Suggested change
| crCli := crfake.NewSimpleClientset() |
| @@ -543,6 +564,9 @@ func (s *ParamsSuite) TestPhaseParams(c *C) { | |||
| c.Assert(err, IsNil) | |||
|
|
|||
| crCli := crfake.NewSimpleClientset() | |||
| pvc, err := s.cli.CoreV1().PersistentVolumeClaims(s.namespace).Get(s.pvc, metav1.GetOptions{}) | |||
| c.Assert(err, IsNil) | |||
| dynCli := s.getDynamicClient(c, pvc) | |||
There was a problem hiding this comment.
[nit]
Suggested change
| dynCli := s.getDynamicClient(c, pvc) | |
| dynCli := s.getDynamicClient(c, pvc) | |
| crCli := crfake.NewSimpleClientset() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
This commit modifies template params creation to always
populate the Object field with the unstructured representation
of the Kubernetes object that is the target of the actionset
This allows writing generic blueprints that can be re-used
across different types of Kubernetes resources and to reference
fields from within the object spec that we do not hoist into
TemplateParams e.g.
.Object.metadata.labels.<foo>The change described is contained to
param.goandparam_test.go.The rest of the changes are to the
kubepkg to allow testing witha fake dynamic client.
Pull request type
Please check the type of change your PR introduces:
Issues
Objectin TemplateParams with unstructured content for well-known types #247Test Plan