Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable gci, goprintffuncname, nolintlint linters #2500

Merged
merged 63 commits into from
Jul 12, 2024
Merged

Enable gci, goprintffuncname, nolintlint linters #2500

merged 63 commits into from
Jul 12, 2024

Conversation

ankitjain235
Copy link
Contributor

@ankitjain235 ankitjain235 commented Nov 29, 2023 •
edited by julio-lopez
Loading

Change Overview

This PR enables gci linter to group imports.

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

ankitjain235 and others added 25 commits August 3, 2023 10:42
@ankitjain235
Enable gocyclo linter
41261a0
@ankitjain235
Enable gocritic linter
118bc8a
@ankitjain235
Fix typo for linters-settings, fix gocyclo lint failures
9fe8ef0
@ankitjain235
Add lll linter
88f1097
@ankitjain235
Add nakedret linter
cf599c9
@ankitjain235
Enable dupl linter
4c91b50
@ankitjain235
Enable exportloopref linter
54d1d5e
@ankitjain235
Enable importas linter
ad04108
@ankitjain235
Enable misspell linter
953121f
@ankitjain235
Enable nestif linter
605f039
@ankitjain235
Fix minor typo
31e838f
@ankitjain235
Merge master, resolve conflicts
b4cf462
@ankitjain235
Update new lint misses, add TODO for lint disables
2f1bbe4
@ankitjain235
Merge master, resolve conflicts
ef78a07
@ankitjain235
Merge master, resolve conflicts
62b8959
@ankitjain235
Merge master, resolve conflicts
41933d9
@ankitjain235
Merge master, resolve conflicts
9c3b9a1
@ankitjain235
Fix misspell lint failure
44a39cb
@ankitjain235
Merge master, resolve conflicts
a874943
@ankitjain235
Apply linter to new changes
612154b
@ankitjain235
Merge master, resolve conflicts
0007316
@ankitjain235
Fix merge issues
7a3945a
@ankitjain235
Merge parent, resolve conflicts
75b4f9d
@ankitjain235
Merge parent, resolve conflicts
bc30421
@ankitjain235
Enable gci linter
d0392d6
@infraq infraq added this to In Progress in Kanister Nov 29, 2023
@ankitjain235 ankitjain235 changed the title Enable gci linter Enable gci, goprintffuncname, nolintlint linters Dec 1, 2023
@github-actions GitHub Actions
Copy link

This PR is marked as stale due to inactivity. Add a new comment to reactivate it.

@github-actions github-actions bot added the stale label Mar 21, 2024
@pavannd1 pavannd1 removed the stale label Mar 21, 2024
viveksinghggits
viveksinghggits reviewed May 31, 2024
View reviewed changes
cmd/reposervercontroller/main.go Show resolved Hide resolved
pkg/client/informers/externalversions/cr/v1alpha1/repositoryserver.go Outdated Show resolved Hide resolved
pkg/client/listers/cr/v1alpha1/repositoryserver.go Outdated Show resolved Hide resolved
pkg/kopia/cli/repository/storage/gcs/gcs_opts_test.go Outdated Show resolved Hide resolved
pkg/kopia/snapshot/stream.go Outdated Show resolved Hide resolved
pkg/kube/exec_test.go Show resolved Hide resolved
ankitjain235
ankitjain235 commented Jul 4, 2024
View reviewed changes
Copy link
Contributor Author

@ankitjain235 ankitjain235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question around why are we disabling default linters.

.golangci.yml Outdated Show resolved Hide resolved
pkg/blockstorage/azure/azuredisk.go Show resolved Hide resolved
viveksinghggits
viveksinghggits reviewed Jul 12, 2024
View reviewed changes
Copy link
Contributor

@viveksinghggits viveksinghggits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cmd/reposervercontroller/main.go Show resolved Hide resolved
pkg/blueprint/validate/validate.go Show resolved Hide resolved
@saima-s saima-s added the kueue label Jul 12, 2024
Kanister automation moved this from In Progress to Reviewer approved Jul 12, 2024
@mergify mergify bot merged commit 80ef874 into master Jul 12, 2024
18 checks passed
Kanister automation moved this from Reviewer approved to Done Jul 12, 2024
@mergify mergify bot deleted the enable-linters-5 branch July 12, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saima-s saima-s saima-s left review comments

@viveksinghggits viveksinghggits viveksinghggits approved these changes

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193

@pavannd1 pavannd1 Awaiting requested review from pavannd1

Assignees
No one assigned
Labels
kueue
Projects
Kanister
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add more linters to golangci.yaml
5 participants
@ankitjain235 @PrasadG193 @viveksinghggits @saima-s @pavannd1