Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable stylecheck linter #2505

Open
wants to merge 86 commits into
base: master
Choose a base branch
from
Open

Enable stylecheck linter #2505

wants to merge 86 commits into from

Conversation

ankitjain235
Copy link
Contributor

Change Overview

This PR enables stylecheck golang linter

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • fixes #issue-number

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

ankitjain235 and others added 29 commits August 3, 2023 10:42
@ankitjain235
Enable gocyclo linter
41261a0
@ankitjain235
Enable gocritic linter
118bc8a
@ankitjain235
Fix typo for linters-settings, fix gocyclo lint failures
9fe8ef0
@ankitjain235
Add lll linter
88f1097
@ankitjain235
Add nakedret linter
cf599c9
@ankitjain235
Enable dupl linter
4c91b50
@ankitjain235
Enable exportloopref linter
54d1d5e
@ankitjain235
Enable importas linter
ad04108
@ankitjain235
Enable misspell linter
953121f
@ankitjain235
Enable nestif linter
605f039
@ankitjain235
Fix minor typo
31e838f
@ankitjain235
Merge master, resolve conflicts
b4cf462
@ankitjain235
Update new lint misses, add TODO for lint disables
2f1bbe4
@ankitjain235
Merge master, resolve conflicts
ef78a07
@ankitjain235
Merge master, resolve conflicts
62b8959
@ankitjain235
Merge master, resolve conflicts
41933d9
@ankitjain235
Merge master, resolve conflicts
9c3b9a1
@ankitjain235
Fix misspell lint failure
44a39cb
@ankitjain235
Merge master, resolve conflicts
a874943
@ankitjain235
Apply linter to new changes
612154b
@ankitjain235
Merge master, resolve conflicts
0007316
@ankitjain235
Fix merge issues
7a3945a
@ankitjain235
Merge parent, resolve conflicts
75b4f9d
@ankitjain235
Merge parent, resolve conflicts
bc30421
@ankitjain235
Enable gci linter
d0392d6
@ankitjain235
Enable goprintffuncname and nolintlint linters
3524aba
@ankitjain235
Enable stylecheck linter
7d10e44
@ankitjain235
Skip stylechecks with minimal change requirements
b8ad05f
@ankitjain235
Remove comment
f267cfd
@infraq infraq added this to In Progress in Kanister Dec 1, 2023
Kanister automation moved this from In Progress to Reviewer approved May 31, 2024
pavannd1
pavannd1 reviewed May 31, 2024
View reviewed changes
pkg/controller/metrics.go Outdated Show resolved Hide resolved
saima-s added 17 commits June 5, 2024 17:30
@saima-s
Merge branch 'master' of github.com:kanisterio/kanister into enable-l…
217e307 
…inters-5
@saima-s
Merge branch 'master' of github.com:kanisterio/kanister into enable-l…
d0e82c8 
…inters-5
@saima-s
fix err check and gci linter
d19d6ce
@saima-s
merge conflict resolved
d744221
@saima-s
disabled stylecheck ST1000 and fix review comment
1e3a653
@saima-s
run go mod tidy
a39e2d2
@saima-s
fix nolintlint error
57b1f33
@saima-s
fix space issue
9cfbeee
@saima-s
merge conflict resolved
fae52fc
@saima-s
enabled default linter
23551f2
@saima-s
Merge branch 'master' into enable-linters-5
12134dc
@saima-s
Merge branch 'enable-linters-5' of github.com:kanisterio/kanister int…
55bcb92 
…o enable-linters-6
@saima-s
enabled default linter
712f628
@saima-s
fix lint
7571875
@saima-s
Merge branch 'enable-linters-5' of github.com:kanisterio/kanister int…
7e1e43d 
…o enable-linters-5
@saima-s
fix unparam linter
80d001e
@saima-s
merge conflict resolved
d01f0db
viveksinghggits
viveksinghggits requested changes Jul 12, 2024
View reviewed changes
pkg/app/couchbase.go Outdated Show resolved Hide resolved
Kanister automation moved this from Reviewer approved to Review Required Jul 12, 2024
@saima-s saima-s added kueue and removed kueue labels Jul 12, 2024
viveksinghggits
viveksinghggits requested changes Jul 12, 2024
View reviewed changes
pkg/app/couchbase.go Outdated Show resolved Hide resolved
pkg/consts/consts.go Show resolved Hide resolved
pkg/metrics/metrics.go Show resolved Hide resolved
pkg/testing/integration_register.go Outdated Show resolved Hide resolved
pkg/testing/integration_register.go Outdated Show resolved Hide resolved
Base automatically changed from enable-linters-5 to master July 12, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hairyhum hairyhum hairyhum left review comments

@pavannd1 pavannd1 pavannd1 left review comments

@saima-s saima-s saima-s left review comments

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193

@viveksinghggits viveksinghggits Awaiting requested review from viveksinghggits

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
Kanister
Review Required
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add more linters to golangci.yaml
6 participants
@ankitjain235 @pavannd1 @hairyhum @PrasadG193 @viveksinghggits @saima-s