Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry on transient error when waiting for snapshot to be ready #2508

Merged
merged 5 commits into from
Dec 8, 2023

Commits on Dec 1, 2023

  1. Retry on transient error when waiting for snapshot to be ready

    CSI snapshot controller might add errors to the snapshot status which it will
    recover from.
    
    Make snapshotter.WaitOnReadyToUse retry (up to 100 times) on those errors.
    Backoff mechanism makes it so 100 retries is minutes, hopefuly should be enough for
    most cases.
    
    Unfortunately CSI snapshotter uses strings to inform of error reason and
    does not provide error code or type when reporting, hence for now we use regexp to
    match on transient error. If CSI snapshotter uses better error format in the future,
    we can also change that.
    hairyhum committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    5b8f944 View commit details
    Browse the repository at this point in the history
  2. Refactor snapshotter.WaitOnReadyToUse to deduplicate retries

    Move retry logic to snapshot.go
    hairyhum committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    fbd6e78 View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2023

  1. Formatting and code cleanup

    hairyhum committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    026debb View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2023

  1. Formatting

    hairyhum committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    ea245c8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    25b1ab0 View commit details
    Browse the repository at this point in the history