Initial fixes to support multi-arch container building

[haimgel]

Change Overview

Here are some assorted fixes to make it possible to build a multi-arch (amd64/arm64) container for Kanister:

1. A tiny fix in the "build" container Dockerfile: it should not constrain the Docker apt repo to amd64 arch only, since arm64 binaries are available there as well. This change makes it possible to build a multi-arch "build" container.
2. Pass ARCH from the Makefile to "goreleaser" and override whatever is specified in goreleaser config file.
3. Revert one change in Specify platform as linux/${ARCH} when cross-building docker images #2503: The license extractor image should not be pinned to the architecture of the container that is being built, they are not related. We should be using the native architecture of the host if possible.

Pull request type

Please check the type of change your PR introduces:

• 🐛 Bugfix

Issues

This is the first step for #2254: I didn't address the CI part of it.

Test Plan

• 💪 Manual

I built a multi-arch image manually on M1 Mac and verified that it works:

# Build the "build" image first
docker build build --platform Linux/amd64,Linux/arm64 -t ghcr.io/haimgel/kanisterio-build:v0.0.25 docker/build
docker push ghcr.io/haimgel/kanisterio-build:v0.0.25

# Build the separate images for ARM64 and AMD64
make build-controller BUILD_IMAGE=ghcr.io/haimgel/kanisterio-build:v0.0.25 ARCH=arm64 
make container BUILD_IMAGE=ghcr.io/haimgel/kanisterio-build:v0.0.25 REGISTRY=ghcr.io/haimgel \
    IMAGE_NAME=kanisterio-controller ARCH=arm64 VERSION=temp-arm64

make build-controller BUILD_IMAGE=ghcr.io/haimgel/kanisterio-build:v0.0.25 ARCH=amd64 
make container BUILD_IMAGE=ghcr.io/haimgel/kanisterio-build:v0.0.25 REGISTRY=ghcr.io/haimgel \ 
    IMAGE_NAME=kanisterio-controller ARCH=amd64 VERSION=temp-amd64

# Unify them into one multi-arch image
manifest-tool push from-args --platforms Linux/amd64,linux/arm64 \
	--template ghcr.io/haimgel/kanisterio-controller:temp-ARCH \
	--target ghcr.io/haimgel/kanisterio-controller:feb02e

[haimgel]

I agree to the DCO for all the commits in this PR.

[hairyhum]

Since this PR addresses Dockerfiles, should it also include things like https://github.com/kanisterio/kanister/pull/2524/files#diff-c925a4382a9e81d94aabbaa91b5e3492cadc2d4f56bc2098bff1a86ae8cf0c67R21 ?
There are few binaries like that being downloaded in Dockerfiles.

[haimgel]

Since this PR addresses Dockerfiles, should it also include things like https://github.com/kanisterio/kanister/pull/2524/files#diff-c925a4382a9e81d94aabbaa91b5e3492cadc2d4f56bc2098bff1a86ae8cf0c67R21 ? There are few binaries like that being downloaded in Dockerfiles.

Good point, it should! I missed Kind because it's not used when building release images. I pushed a commit to address this. I also verified that other dependencies of this image are available for both amd64 and arm64.

I didn't address multi-arch issues in other support Dockerfiles in the repo: i'd rather focus on the controller image and its dependencies first.

[hairyhum]

This resolves into https://github.com/kubernetes-sigs/kind/releases/download/v0.18.0/kind-linux-x86_64 for amd64, so it doesn't exist.
Maybe getting it from the input argument instead of uname would be a better idea.

[haimgel]

This resolves into https://github.com/kubernetes-sigs/kind/releases/download/v0.18.0/kind-linux-x86_64 for amd64, so it doesn't exist. Maybe getting it from the input argument instead of uname would be a better idea.

Sorry about that!

I updated to use the TARGETPLATFORM buildx argument. Buildx was already set up in the GH workflow for the build container, and I also added the platform parameter there to build for both platforms.

[hairyhum]

Tested CI build in https://github.com/kanisterio/kanister/actions/runs/7323462751/job/19946063124

[haimgel]

@hairyhum, thanks for approving my PR! What else is needed to bring it over the finish line and merge?

[hairyhum]

@haimgel automated merge didn't work because of changes in the workflows. Merged manually.