Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set original replica count as op artifact for ScaleWorkload fun #2533

Merged
merged 4 commits into from
Dec 21, 2023

Conversation

viveksinghggits
Copy link
Contributor

Change Overview

This PR updates the ScaleWorkload function in such a way that it now outputs the original replica count of the workload
as output artifact.
After this change, users don't need to figure out the replica count of the workload and set that as output artifact using kando. This will simplify how we use ScaleWorkload function in blueprints.

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

docs/functions.rst Show resolved Hide resolved
docs/tasks/scaleworkload.rst Outdated Show resolved Hide resolved
docs/tasks/scaleworkload.rst Show resolved Hide resolved
pkg/kube/workload.go Outdated Show resolved Hide resolved
pkg/kube/workload.go Outdated Show resolved Hide resolved
pkg/kube/workload.go Show resolved Hide resolved
Copy link
Contributor

@e-sumin e-sumin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except for the suggested change, but it's up to you whether to accept it or not.

@mergify mergify bot merged commit c4ccb53 into master Dec 21, 2023
14 checks passed
@mergify mergify bot deleted the scaleworload-opart branch December 21, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

ScaleWorkload should set the original replica count as output artifact
3 participants