Update golangci-lint to v1.55, fix lint errors #2539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently golangci-lint is built with go version older than the go1.21 This can cause weird linter false-positives (e.g. https://github.com/kanisterio/kanister/actions/runs/7202258335/job/19620056020) Updated version of golangci-lint in the build image Fixed linter warnings: - deprecated rand.Seed - non-sensical return in setupKopiaRepositoryServer
hairyhum
requested review from
mabhi,
PrasadG193 and
viveksinghggits
and removed request for
mabhi
10 tasks
julio-lopez
approved these changes
Dec 15, 2023
| ) | ||
|
|
||
| const characters = "abcdefghijklmnopqrstuvwxyz0123456789" | ||
|
|
||
| func init() { | ||
| rand.Seed(time.Now().UnixNano()) | ||
|
|
|
Hi @hairyhum , |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
Currently golangci-lint is built with go version older than the go1.21 This can cause weird linter false-positives (e.g. https://github.com/kanisterio/kanister/actions/runs/7202258335/job/19620056020)
Updated version of golangci-lint in the build image Fixed linter warnings:
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan