Retry on updating already existing CRD definitions #2540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When updating existing CRD definition we can run into conflict error. This happens often in the test cases. Added `RetryOnConflict` from `client-go` with default parameters for update operation. This should be good enough to reduce test flakes and should not impact the live installations.
|
Looks good to me, thanks @hairyhum . @kale-amruta was also planning to make the same fix. |
viveksinghggits
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
When updating existing CRD definition we can run into conflict error. This happens often in the test cases. For example: https://github.com/kanisterio/kanister/actions/runs/7146506992/job/19464663550#step:7:753
Added
RetryOnConflictfromclient-gowith default parameters for update operation.This should be good enough to reduce test flakes and should not impact the live installations.
Pull request type
Please check the type of change your PR introduces:
Test Plan