Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add script to bump versions. #256

Merged
merged 3 commits into from
Sep 3, 2019
Merged

Add script to bump versions. #256

merged 3 commits into from
Sep 3, 2019

Conversation

tdmanv
Copy link
Contributor

@tdmanv tdmanv commented Aug 29, 2019

Change Overview

Pull request type

Please check the type of change your PR introduces:

  • Work in Progress
  • Refactoring (no functional changes, no api changes)
  • Trival/Minor
  • Bugfix
  • Feature
  • Documentation

Test Plan

https://gist.github.com/tdmanv/ab09da519a49db460cd39fdb293613be

  • Manual
  • Unit test
  • E2E

depohmel
depohmel reviewed Aug 29, 2019
View reviewed changes
Copy link
Contributor

@depohmel depohmel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docker/ folder?

tdmanv
tdmanv commented Aug 29, 2019
View reviewed changes
build/bump_version.sh Outdated Show resolved Hide resolved
@tdmanv
Copy link
Contributor Author

tdmanv commented Aug 29, 2019

docker/ folder?

Good catch, though it does not have any version references, we should still include it

@tdmanv tdmanv merged commit ada0771 into master Sep 3, 2019
@tdmanv tdmanv deleted the bump-script branch September 3, 2019 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@depohmel depohmel depohmel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tdmanv @depohmel