Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CreateRDSSnapshot function by correcting arguments to createSnapshot #2584

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

viveksinghggits
Copy link
Contributor

Change Overview

While refactoring in one of the previous PRs we interchanged two params of a function and because of that we started getting into a problem of DBInstanceIdentifier not specified.
This PR fixes that.

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • πŸ› Bugfix
  • 🌻 Feature
  • πŸ—ΊοΈ Documentation
  • πŸ€– Test

Issues

  • fixes #issue-number

Test Plan

  • πŸ’ͺ Manual
  • ⚑ Unit test
  • πŸ’š E2E

While refactoring in one of the previous PRs we interchanged two
params of a function and because of that we started getting into
a problem of `DBInstanceIdentifier` not specified.
This commit corrects that.
Copy link
Contributor

@kale-amruta kale-amruta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Kanister automation moved this from In Progress to Reviewer approved Jan 2, 2024
@mergify mergify bot merged commit ab2c446 into master Jan 2, 2024
15 checks passed
Kanister automation moved this from Reviewer approved to Done Jan 2, 2024
@mergify mergify bot deleted the fix-createrdssnapshot-fun branch January 2, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants