Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace sigs.k8s.io/kustomize/kyaml/sets with k8s.io/kube-openapi/sets #2593

Merged
merged 2 commits into from
Jan 10, 2024

Conversation

pavannd1
Copy link
Contributor

@pavannd1 pavannd1 commented Jan 10, 2024

Change Overview

  • We have been unable to upgrade the sigs.k8s.io/kustomize/kyaml dependency to v0.13.10 for a while because of a compilation issue. It was only pulled into use the sets library.
    Switching to the kube-openapi version of sets which provides the same functionality and is widely used.

  • This will also unblock K8s lib updates from Dependabot.

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • fixes #issue-number

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@infraq infraq added this to In Progress in Kanister Jan 10, 2024
@pavannd1 pavannd1 added the kueue label Jan 10, 2024
Copy link
Contributor

@kale-amruta kale-amruta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Kanister automation moved this from In Progress to Reviewer approved Jan 10, 2024
@mergify mergify bot merged commit d7473c4 into master Jan 10, 2024
14 checks passed
Kanister automation moved this from Reviewer approved to Done Jan 10, 2024
@mergify mergify bot deleted the replace-kyaml-sets branch January 10, 2024 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants