Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

High level design for starting kopia server in kanister using kopia SDK #2597

Merged
merged 9 commits into from
Apr 16, 2024
Merged

High level design for starting kopia server in kanister using kopia SDK #2597

merged 9 commits into from
Apr 16, 2024

Conversation

kale-amruta
Copy link
Contributor

@kale-amruta kale-amruta commented Jan 11, 2024 •
edited
Loading

Change Overview

The design document explains the changes required in repository server controller to start using kopia SDK

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • fixes #issue-number

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@infraq infraq added this to In Progress in Kanister Jan 11, 2024
@kale-amruta
HLD for storage wrappers library
78a8f33 
Signed-off-by: Amruta Kale <amruta.kale@veeam.com>
@kale-amruta kale-amruta marked this pull request as ready for review January 16, 2024 08:30
@kale-amruta kale-amruta changed the title High level design for building a wrapper library using kopia SDK for repository operations High level design for starting kopia server in kanister using kopia SDK Jan 18, 2024
PrasadG193
PrasadG193 reviewed Jan 25, 2024
View reviewed changes
design/kanister-kopia-integration.md Outdated Show resolved Hide resolved
design/replace-CLI-with-SDK.md Outdated Show resolved Hide resolved
design/kanister-kopia-integration.md Outdated Show resolved Hide resolved
design/kanister-kopia-integration.md Outdated Show resolved Hide resolved
design/replace-CLI-with-SDK.md Outdated Show resolved Hide resolved
design/replace-CLI-with-SDK.md Outdated Show resolved Hide resolved
design/replace-CLI-with-SDK.md Show resolved Hide resolved
design/replace-CLI-with-SDK.md Show resolved Hide resolved
design/replace-CLI-with-SDK.md Show resolved Hide resolved
design/replace-CLI-with-SDK.md Outdated Show resolved Hide resolved
PrasadG193
PrasadG193 approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@PrasadG193 PrasadG193 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left comments with minor suggestions. Overall looks good to me.

design/replace-CLI-with-SDK.md Outdated Show resolved Hide resolved
design/replace-CLI-with-SDK.md Outdated Show resolved Hide resolved
design/replace-CLI-with-SDK.md Show resolved Hide resolved
Kanister automation moved this from In Progress to Reviewer approved Feb 12, 2024
@kale-amruta kale-amruta force-pushed the kopiaKanisterIntegrationPhase2 branch from 9ba7196 to 91c0e05 Compare April 16, 2024 08:11
@mergify mergify bot merged commit 6ac3818 into master Apr 16, 2024
16 checks passed
Kanister automation moved this from Reviewer approved to Done Apr 16, 2024
@mergify mergify bot deleted the kopiaKanisterIntegrationPhase2 branch April 16, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PrasadG193 PrasadG193 PrasadG193 approved these changes

@pavannd1 pavannd1 Awaiting requested review from pavannd1

Assignees
No one assigned
Labels
kueue
Projects
Kanister
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kale-amruta @PrasadG193