-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(release): add reno tools to build image and makefile #2604
Conversation
2c3ec35
to
0429c34
Compare
0429c34
to
1bf1538
Compare
81ff51e
to
829dd7c
Compare
275e217
to
79ff7b7
Compare
Generate CHANGELOG.md and CHANGELOG_CURRENT.md with `make reno-report` in order to commit them on pre-release step. Pick up CHANGELOG_CURRENT.md on `make gorelease`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, after addressing few minor comments.
releasenotes/README.md
Outdated
CHANGELOG_CURRENT.md only containing changes for the current version. | ||
|
||
It will be used when running goreleaser build using make (will use `CHANGELOG_CURRENT.md` by default): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should these sentences be together?
Also CHANGELOG_CURRENT.md only containing changes for the current version.
doesn't seem right.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also CHANGELOG_CURRENT.md only containing changes for the current version. doesn't seem right.
Can you elaborate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rephrased
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Change Overview
Tooling to make use of reno release notes generation tool
Pull request type
Please check the type of change your PR introduces: