Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Kopia storage filesystem opts #2656

Merged
merged 48 commits into from
Mar 5, 2024
Merged

Implement Kopia storage filesystem opts #2656

merged 48 commits into from
Mar 5, 2024

Conversation

plar
Copy link
Contributor

@plar plar commented Feb 6, 2024 •
edited
Loading

Change Overview

This PR is the 4th in the series of PRs that will add a new way to build Kopia CLI commands.

PR Train:

  1. PR-2653 Introducing a new approach to building Kopia CLI commands using safecli v0.0.6
  2. PR-2654 Implement Kopia common args and opts
  3. PR-2655 Implement Kopia storage helpers
  4. PR-2656 Add Kopia Filesystem storage opts
  5. PR-2657 Add Kopia GCS storage opts
  6. PR-2658 Add Kopia Azure storage opts
  7. PR-2659 Add Kopia S3 and S3 compliant storage opts
  8. PR-2661 Add Kopia repository create command
  9. PR-2662 Add Kopia repository connect command
  10. PR-2663 Add Kopia repository connect server command
  11. PR-2664 Add Kopia repository set-parameters command
  12. PR-2665 Add Kopia repository status command

This PR introduces storage filesystem flag structures which will be used to build storage flags for filesystem storage.

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@plar plar requested review from Shrekster and pavannd1 February 6, 2024 23:06
@plar plar self-assigned this Feb 6, 2024
This was referenced Feb 6, 2024
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
@plar plar changed the title Implement Kopia CLI storage filesystem flags Implement Kopia storage filesystem flags Feb 7, 2024
This was referenced Feb 7, 2024
Merged
Merged
Merged
hairyhum
hairyhum reviewed Feb 7, 2024
View reviewed changes
pkg/kopia/cli/internal/command/command.go Outdated Show resolved Hide resolved
pkg/kopia/cli/internal/command/command.go Outdated Show resolved Hide resolved
pkg/kopia/cli/internal/command/command.go Outdated Show resolved Hide resolved
pkg/kopia/cli/internal/flag/storage/storage.go Outdated Show resolved Hide resolved
@plar
Fix Apply and test.Suit
9850f4a 
Signed-off-by: pavel.larkin <pavel.larkin@veeam.com>
plar added 9 commits February 28, 2024 09:02
@plar
Fix Apply and test.Suit
bcafabb 
Signed-off-by: pavel.larkin <pavel.larkin@veeam.com>
@plar
pkg/kopia/cli/internal/flag is implemented in the safecli@v0.0.4 now
6d61bb4 
Signed-off-by: pavel.larkin <pavel.larkin@veeam.com>
@plar
Add pkg/kopia/cli package
e6ddb8f 
Signed-off-by: pavel.larkin <pavel.larkin@veeam.com>
@plar
go mod tidy
4e7ffd7 
Signed-off-by: pavel.larkin <pavel.larkin@veeam.com>
@plar
Update safecli to v0.0.5
f16aea7 
Signed-off-by: pavel.larkin <pavel.larkin@veeam.com>
@plar
Update safecli to v0.0.6
dcd6425 
Signed-off-by: pavel.larkin <pavel.larkin@veeam.com>
@plar
Sync with upstream
d3dfb31 
Signed-off-by: pavel.larkin <pavel.larkin@veeam.com>
@plar
Merge branch 'kopia-cli-common-flags' into kopia-cli-storage-core-flags
d2ac987
@plar
Merge branch 'kopia-cli-storage-core-flags' into kopia-cli-storage-fs…
dfa748c 
…-flags
plar added 11 commits February 28, 2024 14:58
@plar
Fix tests
b093421 
Signed-off-by: pavel.larkin <pavel.larkin@veeam.com>
@plar
Merge branch 'kopia-cli-common-flags' into kopia-cli-storage-core-flags
6e71143
@plar
Add Location.IsPointInTypeSupported
de3a52b 
Signed-off-by: pavel.larkin <pavel.larkin@veeam.com>
@plar
Add tests for Location.IsPointInTypeSupported
722b279 
Signed-off-by: pavel.larkin <pavel.larkin@veeam.com>
@plar
Merge branch 'kopia-cli-storage-core-flags' into kopia-cli-storage-fs…
71a5aa5 
…-flags
@plar
Fix formatting
44c133e 
Signed-off-by: pavel.larkin <pavel.larkin@veeam.com>
@plar
Merge branch 'kopia-cli-core-infra' into kopia-cli-common-flags
1897a1e
@plar
organize imports
33b1342 
Signed-off-by: pavel.larkin <pavel.larkin@veeam.com>
@plar
Merge branch 'kopia-cli-common-flags' into kopia-cli-storage-core-flags
83292af
@plar
organize imports
516a14c 
Signed-off-by: pavel.larkin <pavel.larkin@veeam.com>
@plar
Merge branch 'kopia-cli-storage-core-flags' into kopia-cli-storage-fs…
9d7d01d 
…-flags
kale-amruta
kale-amruta approved these changes Mar 1, 2024
View reviewed changes
Copy link
Contributor

@kale-amruta kale-amruta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Base automatically changed from kopia-cli-storage-core-flags to master March 5, 2024 20:00
@plar plar added the kueue label Mar 5, 2024
@mergify mergify bot merged commit 4cddac3 into master Mar 5, 2024
14 checks passed
@mergify mergify bot deleted the kopia-cli-storage-fs-flags branch March 5, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kale-amruta kale-amruta kale-amruta approved these changes

@ankitjain235 ankitjain235 ankitjain235 approved these changes

@hairyhum hairyhum hairyhum approved these changes

@Shrekster Shrekster Awaiting requested review from Shrekster

@pavannd1 pavannd1 Awaiting requested review from pavannd1

Assignees

@plar plar

Labels
enhancement kueue
Projects
Kanister
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@plar @hairyhum @ankitjain235 @kale-amruta