feat!: remove unused blockstorage providers #2666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hairyhum
force-pushed
the
blockstorage-unused-providers
branch
from
19cb066
to
bf33625
Compare
hairyhum
force-pushed
the
blockstorage-unused-providers
branch
from
bf33625
to
5577c00
Compare
hairyhum
force-pushed
the
blockstorage-unused-providers
branch
from
5577c00
to
dfed5f1
Compare
Currently vmware and efs blockstorage providers cannot be used from functions. We decided to eventually remove blockstorage package in favour of CSI interfaces, hence these providers will not be used in the future. BREAKING CHANGES: for applications using kanister code as a dependency this change removes two packages `github.com/kanisterio/kanister/pkg/blockstorage/vmware` and `github.com/kanisterio/kanister/pkg/blockstorage/awsefs`
hairyhum
force-pushed
the
blockstorage-unused-providers
branch
from
dfed5f1
to
d5fd066
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
Currently vmware and efs blockstorage providers cannot be used from functions. We decided to eventually remove blockstorage package in favour of CSI interfaces, hence these providers will not be used in the future.
BREAKING CHANGES: for applications using kanister code as a dependency this change
removes two packages
github.com/kanisterio/kanister/pkg/blockstorage/vmwareandgit.luolix.top/kanisterio/kanister/pkg/blockstorage/awsefsPull request type
Please check the type of change your PR introduces:
Issues
Test Plan