Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an e2e test #269

Merged
merged 2 commits into from
Sep 10, 2019
Merged

Add an e2e test #269

merged 2 commits into from
Sep 10, 2019

Conversation

tdmanv
Copy link
Contributor

@tdmanv tdmanv commented Sep 9, 2019

Change Overview

Adds a test which exercises an entire workflow for KubeExec

Pull request type

Please check the type of change your PR introduces:

  • Work in Progress
  • Refactoring (no functional changes, no api changes)
  • Trival/Minor
  • Bugfix
  • Feature
  • Documentation
  • Test

Test Plan

/go/src/github.com/kanisterio/kanister # go test -v ./pkg/testing/ -check.v
=== RUN   Test
time="2019-09-09T00:20:57Z" level=info msg="Added blueprint test-blueprint-99jw7"
time="2019-09-09T00:20:57Z" level=info msg="Executing action test"
time="2019-09-09T00:20:57Z" level=info msg="Created actionset test-actionset-s9dw5 and started executing actions"
time="2019-09-09T00:20:57Z" level=info msg="Executing phase test-kube-exec"
time="2019-09-09T00:20:57Z" level=info msg="Updated ActionSet 'test-actionset-s9dw5' Status->pending"
time="2019-09-09T00:20:57Z" level=info msg="Updated ActionSet 'test-actionset-s9dw5' Status->running, Phase: test-kube-exec->pending"
time="2019-09-09T00:20:57Z" level=info msg="Pod: test-deployment-h98mw-6f6955dfd7-rfwkt Container: test-container Out: hello echo hello"
time="2019-09-09T00:20:57Z" level=info msg="Completed phase test-kube-exec"
time="2019-09-09T00:20:57Z" level=info msg="Updated ActionSet 'test-actionset-s9dw5' Status->complete"
PASS: e2e_test.go:83: E2ESuite.TestKubeExec     2.048s
OK: 1 passed
--- PASS: Test (3.66s)
PASS
ok      github.com/kanisterio/kanister/pkg/testing      3.677s
  • Manual
  • Unit test
  • E2E

Copy link
Contributor

@ewhamilton ewhamilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tdmanv tdmanv requested a review from depohmel September 9, 2019 15:42
@pavannd1
Copy link
Contributor

pavannd1 commented Sep 9, 2019

💯

@tdmanv tdmanv merged commit 54205b7 into master Sep 10, 2019
@tdmanv tdmanv deleted the e2e branch September 10, 2019 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants