Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps(go): bump github.com/prometheus/client_golang from 1.18.0 to 1.19.0 #2715

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 4, 2024

Bumps github.com/prometheus/client_golang from 1.18.0 to 1.19.0.

Release notes

Sourced from github.com/prometheus/client_golang's releases.

v1.19.0

What's Changed

The module prometheus/common v0.48.0 introduced an incompatibility when used together with client_golang (See prometheus/client_golang#1448 for more details). If your project uses client_golang and you want to use prometheus/common v0.48.0 or higher, please update client_golang to v1.19.0.

  • [CHANGE] Minimum required go version is now 1.20 (we also test client_golang against new 1.22 version). #1445 #1449
  • [FEATURE] collectors: Add version collector. #1422 #1427

New Contributors

Full Changelog: prometheus/client_golang@v1.18.0...v1.19.0

Changelog

Sourced from github.com/prometheus/client_golang's changelog.

1.19.0 / 2023-02-27

The module prometheus/common v0.48.0 introduced an incompatibility when used together with client_golang (See prometheus/client_golang#1448 for more details). If your project uses client_golang and you want to use prometheus/common v0.48.0 or higher, please update client_golang to v1.19.0.

  • [CHANGE] Minimum required go version is now 1.20 (we also test client_golang against new 1.22 version). #1445 #1449
  • [FEATURE] collectors: Add version collector. #1422 #1427
Commits
  • 77d4003 Add 1.19.0 changelog (#1451)
  • 14259fa Merge pull request #1448 from ywwg/owilliams/content-negotiation
  • 6d03920 deps: bump prometheus/common version
  • 353395b Remove support for go 1.19 (#1449)
  • 9dd5d2a Merge pull request #1445 from kavu/add_go122_metrics_test
  • c906a5e Add support for Go 1.22
  • 7ac9036 Merge pull request #1440 from prometheus/dependabot/github_actions/github-act...
  • 8c7e30f Merge pull request #1441 from prometheus/dependabot/go_modules/tutorial/whats...
  • 08769f8 Bump github.com/prometheus/common in /tutorial/whatsup
  • 83d5940 Bump the github-actions group with 2 updates
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Mar 4, 2024
@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/prometheus/client_golang-1.19.0 branch 4 times, most recently from 22fc13f to 839f797 Compare March 6, 2024 20:34
@hairyhum
Copy link
Contributor

hairyhum commented Mar 6, 2024

@dependabot rebase

Copy link
Contributor Author

dependabot bot commented on behalf of github Mar 6, 2024

Looks like this PR is already up-to-date with master! If you'd still like to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@pavannd1 pavannd1 requested a review from AKhoria March 6, 2024 21:28
@pavannd1 pavannd1 added kueue and removed kueue labels Mar 6, 2024
@pavannd1
Copy link
Contributor

pavannd1 commented Mar 6, 2024

Looks like there's some incompatibility with Kopia. We can triage and resolve it next week.

@pavannd1 pavannd1 requested review from redgoat650 and ankitjain235 and removed request for AKhoria March 6, 2024 21:40
Copy link
Contributor

@pavannd1 pavannd1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a block until we debug kopia issues

@hairyhum
Copy link
Contributor

hairyhum commented Mar 6, 2024

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/prometheus/client_golang-1.19.0 branch from 839f797 to caaa2d5 Compare March 6, 2024 22:15
@julio-lopez
Copy link
Contributor

julio-lopez commented Mar 6, 2024

This requires a couple of code changes.
Kopia addressed them here: kopia/kopia@ba54dc3d

The likely course of action here to upgrade kopia, that will in turn upgrade prometheus.

Are there any other compilation errors that need to be addressed on the kanister side?

@hairyhum @pavannd1

@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/prometheus/client_golang-1.19.0 branch 2 times, most recently from e81dcc8 to 3d423ab Compare March 12, 2024 04:56
@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/prometheus/client_golang-1.19.0 branch 4 times, most recently from da0cb6a to f183e16 Compare March 15, 2024 17:03
@julio-lopez
Copy link
Contributor

@dependabot update

@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/prometheus/client_golang-1.19.0 branch 3 times, most recently from 2e3bc60 to a3a4204 Compare March 19, 2024 18:35
@julio-lopez
Copy link
Contributor

#2767

@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/prometheus/client_golang-1.19.0 branch from a3a4204 to c2d5046 Compare March 19, 2024 21:27
Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.18.0 to 1.19.0.
- [Release notes](https://github.com/prometheus/client_golang/releases)
- [Changelog](https://github.com/prometheus/client_golang/blob/main/CHANGELOG.md)
- [Commits](prometheus/client_golang@v1.18.0...v1.19.0)

---
updated-dependencies:
- dependency-name: github.com/prometheus/client_golang
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/prometheus/client_golang-1.19.0 branch from c2d5046 to fc803bc Compare March 19, 2024 22:00
Copy link
Contributor Author

dependabot bot commented on behalf of github Mar 20, 2024

Looks like github.com/prometheus/client_golang is up-to-date now, so this is no longer needed.

@dependabot dependabot bot closed this Mar 20, 2024
@dependabot dependabot bot deleted the dependabot/go_modules/github.com/prometheus/client_golang-1.19.0 branch March 20, 2024 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants