Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove special handling for old bug in dell vxflex csi driver #2716

Merged
merged 2 commits into from
Mar 6, 2024

Conversation

bathina2
Copy link
Contributor

@bathina2 bathina2 commented Mar 4, 2024

Change Overview

This PR removes changes that manually set the status for Dell vxflex csi driver.
In the past we manually set this because of the following bug in the driver where the status was never set to ready to use-
dell/csi-powerflex#11
Now that this bug is fixed we should just rely on the snapshot provisioner to handle the status field of a volume snapshot.

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • fixes #issue-number

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@infraq infraq added this to In Progress in Kanister Mar 4, 2024
Copy link
Contributor

@redgoat650 redgoat650 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Kanister automation moved this from In Progress to Reviewer approved Mar 5, 2024
@bathina2 bathina2 added the kueue label Mar 6, 2024
@pavannd1 pavannd1 merged commit 2c54831 into master Mar 6, 2024
12 of 14 checks passed
Kanister automation moved this from Reviewer approved to Done Mar 6, 2024
@pavannd1 pavannd1 deleted the remove_special_handling_vxflexcsi branch March 6, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants