Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve TransformUnstructured; Log GVK, type value #2717

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

tdmanv
Copy link
Contributor

@tdmanv tdmanv commented Mar 5, 2024

Change Overview

Improves TransformUnstructured

  • Adds a nil check for u
  • Logs the GroupdVersionKind on Serialization errors
  • Types the struct as metav1.Object instead of interface{}

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Test Plan

kanister/pkg/kube/snapshot/ go test -check.f TestNilUnstructured
OK: 1 passed
PASS
ok      github.com/kanisterio/kanister/pkg/kube/snapshot        0.029s
  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@infraq infraq added this to In Progress in Kanister Mar 5, 2024
Copy link
Contributor

@pavannd1 pavannd1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Kanister automation moved this from In Progress to Reviewer approved Mar 5, 2024
@tdmanv tdmanv added the kueue label Mar 5, 2024
@mergify mergify bot merged commit ba26708 into master Mar 5, 2024
14 checks passed
Kanister automation moved this from Reviewer approved to Done Mar 5, 2024
@mergify mergify bot deleted the tdmanv/transform-safety branch March 5, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants