Initial structure of log repo #272
Conversation
SupriyaKasten
changed the title
pkg/log/log.go
Outdated
| type logLevel string | ||
|
|
||
| const ( | ||
| logTypeInfo logLevel = "Info" |
There was a problem hiding this comment.
Rather than use string literals, please use the constants from logrus
| ) | ||
|
|
||
| type logger struct { | ||
| level Level |
There was a problem hiding this comment.
We can revise the implementation later. For now, this interface helps modifying / adding the call points.
|
@julio-lopez I did not commit your suggestions directly since I wanted to make some more changes. Pushed a PR with your suggestions, Ready for another review! |
pkg/log/log.go
Outdated
| @@ -47,22 +47,24 @@ func WithContext(ctx context.Context) { | |||
| } | |||
|
|
|||
| func (l *logger) Print(msg string) { | |||
| var message interface{} | |||
There was a problem hiding this comment.
it was failing before with: pkg/log/log.go:52:14: cannot use msg (type string) as type []interface {} in argument to logrus.Info
There was a problem hiding this comment.
Oh I think I know where I went wrong! pushing an updated PR.
There was a problem hiding this comment.
Sorry for the confusion @julio-lopez, I was calling logrus.Info(msg...) instead if logrus.Info(msg). Fixing it now
Change Overview
Make logs more descriptive and easy to use & read
This task will be divided in small PRs and merged
This PR is the initial structure of the log repo
Pull request type
Please check the type of change your PR introduces: