fix(logs): Fix duplication of logs sent to fluentbit #2722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e-sumin
force-pushed
the
fix_logs_duplication
branch
from
2c9bbea
to
75e60ed
Compare
e-sumin
force-pushed
the
fix_logs_duplication
branch
from
75e60ed
to
9b68dab
Compare
|
Can we add a test to prevent a future regression please? |
|
@julio-lopez added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
Currently we have an issue with logger, when SetOutput is invoked with the
FluentbitSinkoutput, each logged messages is sent to fluentbit 7 times.The issue is caused by
cloneGlobalLogger, when we are iterating hooks and adding each hook to the entry, we are actually adding each hook 7 times (logrus internally iterates over each hook levels (7 is a number of log levels supported by hook).Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan