Remove --pull from images using kanister-tools as base

[pavannd1]

Change Overview

Using --pull flag when building docker images that try to pull kanister-tools:{RELEASE_TAG} from upstream fails. The image doesn't exist yet since the release job first builds all the images and then pushes them to ghcr.

Example failure:

[2024-03-07T02:43:24.758Z]     • building docker image                          image=ghcr.io/kanisterio/mongodb:0.106.0
[2024-03-07T02:43:24.778Z]     • running                                        args=[. -t ghcr.io/kanisterio/mongodb:0.106.0 --pull --build-arg=TOOLS_IMAGE=ghcr.io/kanisterio/kanister-tools:0.106.0] cmd=[docker build] cwd=dist/goreleaserdocker4266236303
[2024-03-07T02:43:24.835Z]     • #0 building with "default" instance using docker driver cmd=[docker build] cwd=dist/goreleaserdocker4266236303
[2024-03-07T02:43:24.835Z]     •                                                cmd=[docker build] cwd=dist/goreleaserdocker4266236303
[2024-03-07T02:43:24.835Z]     • #1 [internal] load build definition from Dockerfile cmd=[docker build] cwd=dist/goreleaserdocker4266236303
[2024-03-07T02:43:24.835Z]     • #1 transferring dockerfile: 392B done          cmd=[docker build] cwd=dist/goreleaserdocker4266236303
[2024-03-07T02:43:24.835Z]     • #1 DONE 0.0s                                   cmd=[docker build] cwd=dist/goreleaserdocker4266236303
[2024-03-07T02:43:24.835Z]     •                                                cmd=[docker build] cwd=dist/goreleaserdocker4266236303
[2024-03-07T02:43:24.835Z]     • #2 [internal] load .dockerignore               cmd=[docker build] cwd=dist/goreleaserdocker4266236303
[2024-03-07T02:43:24.835Z]     • #2 transferring context: 2B done               cmd=[docker build] cwd=dist/goreleaserdocker4266236303
[2024-03-07T02:43:24.835Z]     • #2 DONE 0.0s                                   cmd=[docker build] cwd=dist/goreleaserdocker4266236303
[2024-03-07T02:43:24.835Z]     •                                                cmd=[docker build] cwd=dist/goreleaserdocker4266236303
[2024-03-07T02:43:24.835Z]     • #3 [internal] load metadata for ghcr.io/kanisterio/kanister-tools:0.106.0 cmd=[docker build] cwd=dist/goreleaserdocker4266236303
[2024-03-07T02:43:24.858Z]     • #3 ERROR: ghcr.io/kanisterio/kanister-tools:0.106.0: not found cmd=[docker build] cwd=dist/goreleaserdocker4266236303
[2024-03-07T02:43:24.858Z]     •                                                cmd=[docker build] cwd=dist/goreleaserdocker4266236303
[2024-03-07T02:43:24.858Z]     • #4 [internal] load metadata for docker.io/bitnami/mongodb:7.0-debian-12 cmd=[docker build] cwd=dist/goreleaserdocker4266236303
[2024-03-07T02:43:24.858Z]     • #4 CANCELED                                    cmd=[docker build] cwd=dist/goreleaserdocker4266236303
[2024-03-07T02:43:24.858Z]     • ------                                         cmd=[docker build] cwd=dist/goreleaserdocker4266236303
[2024-03-07T02:43:24.858Z]     •  > [internal] load metadata for ghcr.io/kanisterio/kanister-tools:0.106.0: cmd=[docker build] cwd=dist/goreleaserdocker4266236303
[2024-03-07T02:43:24.858Z]     • ------                                         cmd=[docker build] cwd=dist/goreleaserdocker4266236303
[2024-03-07T02:43:24.858Z]     • Dockerfile:4                                   cmd=[docker build] cwd=dist/goreleaserdocker4266236303
[2024-03-07T02:43:24.858Z]     • --------------------                           cmd=[docker build] cwd=dist/goreleaserdocker4266236303
[2024-03-07T02:43:24.859Z]     •    2 |     # Tools are not up to date in debian repos cmd=[docker build] cwd=dist/goreleaserdocker4266236303
[2024-03-07T02:43:24.859Z]     •    3 |     ARG TOOLS_IMAGE                     cmd=[docker build] cwd=dist/goreleaserdocker4266236303
[2024-03-07T02:43:24.859Z]     •    4 | >>> FROM ${TOOLS_IMAGE} AS TOOLS_IMAGE  cmd=[docker build] cwd=dist/goreleaserdocker4266236303
[2024-03-07T02:43:24.859Z]     •    5 |                                         cmd=[docker build] cwd=dist/goreleaserdocker4266236303
[2024-03-07T02:43:24.862Z]     •    6 |     FROM bitnami/mongodb:7.0-debian-12  cmd=[docker build] cwd=dist/goreleaserdocker4266236303
[2024-03-07T02:43:24.862Z]     • --------------------                           cmd=[docker build] cwd=dist/goreleaserdocker4266236303
[2024-03-07T02:43:24.862Z]     • ERROR: failed to solve: ghcr.io/kanisterio/kanister-tools:0.106.0: ghcr.io/kanisterio/kanister-tools:0.106.0: not found cmd=[docker build] cwd=dist/goreleaserdocker4266236303

Pull request type

Please check the type of change your PR introduces:

• 🚧 Work in Progress
• 🌈 Refactoring (no functional changes, no api changes)
• 🐹 Trivial/Minor
• 🐛 Bugfix
• 🌻 Feature
• 🗺️ Documentation
• 🤖 Test

Issues

• fixes #issue-number

Test Plan

• 💪 Manual
• ⚡ Unit test
• 💚 E2E