fix(tests): Fix flaky TestCloneGlobalLogger #2775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viveksinghggits
approved these changes
Mar 21, 2024
pkg/log/log_test.go
Outdated
| } | ||
|
|
||
| type testLogHook struct{} | ||
| type testLogHook struct { |
There was a problem hiding this comment.
Nit: should we call it just logHook?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
Due to asynchronous nature of FluentbitHook test was not always passing. I've replaced it with synchronous hook, which guarantees the order of execution.
Pull request type
Please check the type of change your PR introduces:
Issues
LogSuite.TestCloneGlobalLoggertest fails frequently #2761Test Plan