Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark ephemeral pods created as part of kanister functions with JobID label #2778

Merged
merged 22 commits into from
Apr 5, 2024
Merged
Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pkg/function/kube_task.go
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,8 @@ func kubeTask(ctx context.Context, cli kubernetes.Interface, namespace, image st
Command: command,
PodOverride: podOverride,
}
// Mark labels to pods with prefix `kanister.io`. Add the jobID as reference to the origin for the pod.
mabhi marked this conversation as resolved.
Show resolved Hide resolved
kube.AddLabelsToPodOptionsFromContext(ctx, options, consts.LabelPrefix, "JobID")
mabhi marked this conversation as resolved.
Show resolved Hide resolved

pr := kube.NewPodRunner(cli, options)
podFunc := kubeTaskPodFunc()
Expand Down
61 changes: 61 additions & 0 deletions pkg/kube/pod_runner_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,15 @@ import (
"context"
"os"

"github.com/pkg/errors"
. "gopkg.in/check.v1"
corev1 "k8s.io/api/core/v1"
"k8s.io/apimachinery/pkg/runtime"
"k8s.io/client-go/kubernetes/fake"
"k8s.io/client-go/testing"

"github.com/kanisterio/kanister/pkg/consts"
"github.com/kanisterio/kanister/pkg/field"
)

type PodRunnerTestSuite struct{}
Expand Down Expand Up @@ -109,9 +113,66 @@ func (s *PodRunnerTestSuite) TestPodRunnerForSuccessCase(c *C) {
cancel()
}

// TestPodRunnerWithJobIDDebugLabelForSuccessCase: This test adds a debug entry (kanister.io/JobID) into the context and verifies the
// pod got created with corresponding label using the entry or not.
func (s *PodRunnerTestSuite) TestPodRunnerWithJobIDDebugLabelForSuccessCase(c *C) {
ctx, cancel := context.WithCancel(context.Background())
randomUUID := "xyz123"
ctx = field.Context(ctx, consts.LabelPrefix+"JobID", randomUUID)
mabhi marked this conversation as resolved.
Show resolved Hide resolved
ctx = field.Context(ctx, "some-test-key", "some-test-value")

cli := fake.NewSimpleClientset()
cli.PrependReactor("create", "pods", func(action testing.Action) (handled bool, ret runtime.Object, err error) {
return false, nil, nil
})
cli.PrependReactor("get", "pods", func(action testing.Action) (handled bool, ret runtime.Object, err error) {
p := &corev1.Pod{
Status: corev1.PodStatus{
Phase: corev1.PodRunning,
},
}
return true, p, nil
})
deleted := make(chan struct{})
cli.PrependReactor("delete", "pods", func(action testing.Action) (handled bool, ret runtime.Object, err error) {
c.Log("Pod deleted due to Context Cancelled")
close(deleted)
return true, nil, nil
})
po := &PodOptions{
Namespace: podRunnerNS,
Name: podName,
Command: []string{"sh", "-c", "tail -f /dev/null"},
}
AddLabelsToPodOptionsFromContext(ctx, po, consts.LabelPrefix, "JobID")
pr := NewPodRunner(cli, po)
errorCh := make(chan error)
go func() {
_, err := pr.Run(ctx, makePodRunnerTestForKeyPresence(consts.LabelPrefix+"JobID", randomUUID, deleted))
errorCh <- err
}()
deleted <- struct{}{}
c.Assert(<-errorCh, IsNil)
cancel()
}

func makePodRunnerTestFunc(ch chan struct{}) func(ctx context.Context, pc PodController) (map[string]interface{}, error) {
return func(ctx context.Context, pc PodController) (map[string]interface{}, error) {
<-ch
return nil, nil
}
}

func makePodRunnerTestForKeyPresence(labelKey, labelValue string, ch chan struct{}) func(ctx context.Context, pc PodController) (map[string]interface{}, error) {
return func(ctx context.Context, pc PodController) (map[string]interface{}, error) {
<-ch
value, ok := pc.Pod().Labels[labelKey]
if !ok {
return nil, errors.New("Key not present")
}
if value != labelValue {
return nil, errors.New("Value mismatch")
}
return nil, nil
}
}
22 changes: 22 additions & 0 deletions pkg/kube/utils.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,13 @@ package kube
import (
"context"
"fmt"
"strings"

osversioned "github.com/openshift/client-go/apps/clientset/versioned"
corev1 "k8s.io/api/core/v1"
"k8s.io/client-go/kubernetes"

"github.com/kanisterio/kanister/pkg/field"
)

const (
Expand Down Expand Up @@ -171,3 +174,22 @@ func PVCContainsReadOnlyAccessMode(pvc *corev1.PersistentVolumeClaim) bool {

return false
}

// AddLabelsToPodOptionsFromContext adds additional label selector to `PodOptions`,
// provided the context has a key starting with `keyPrefix`.
func AddLabelsToPodOptionsFromContext(ctx context.Context, options *PodOptions, keyPrefix, keySuffix string) {
fields := field.FromContext(ctx)
if fields == nil {
return
}
for _, f := range fields.Fields() {
if !strings.HasPrefix(f.Key(), keyPrefix) {
continue
}
value := f.Value().(string)
if options.Labels == nil {
options.Labels = make(map[string]string)
}
options.Labels[keyPrefix+keySuffix] = value
}
}