An implementation for field.Field #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julio-lopez
force-pushed
the
field-impl
branch
from
bb9dca1
to
ae50e9d
Compare
|
Minimum number of exported functions. We may need to add other functions/helpers down the road to support other use cases for logging and errors. |
julio-lopez
force-pushed
the
field-impl
branch
2 times, most recently
from
41d2b63
to
3050d03
Compare
tdmanv
approved these changes
Sep 11, 2019
Linked-list based implementation. The approach attempts to prevent/limit the mutability of the fields outside the `field` package. Also, in the package the contents of `linkedField struct` are not modified after the struct has been created.
julio-lopez
force-pushed
the
field-impl
branch
from
3050d03
to
9ed28ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
Linked-list based implementation.
The approach attempts to prevent/limit the mutability of the fields outside the
fieldpackage.Also, in the package the contents of
linkedField structare not modified after the struct has been created.Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan