Don't change roles in methods other than constructor #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hakanmemisoglu
changed the title
hakanmemisoglu
changed the title
tdmanv
approved these changes
Sep 10, 2019
hakanmemisoglu
force-pushed
the
dont-change-role
branch
from
ce6194c
to
bfb6b3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
Role will be assumed in the constructor.
Changing role in other methods will cause double assume role problem and probably will give an AccessDenied problem.
Fix the problem by giving empty string as role in methods other than the constructor.
Pull request type
Please check the type of change your PR introduces: