Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Take control over Kopia log level #2842
Take control over Kopia log level #2842
Changes from 5 commits
83ecc63
2d9fe1c
e283654
83be3c4
729c5d6
bb887cc
7936745
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Eugen,
First off, thanks for log flags! I've missed them recently (and hard-coded locally for tests) :).
What do you think about encapsulating the defaulting logic within envvar utility funcs?
For example, we could use a generic function like
nonEmptyOrDefault
to handle defaults more elegantly.Here’s an example of what this might look like:
and after we can refactor
commonArgs
as:OLD
NEW
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
accepted, done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These tests do not need to use
check.v1
and could be built using the support in the plain Gotesting
package.Since this is (was) a new test, wouldn't it make sense to avoid
check.v1
here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'd be good to use
testing.T.Setenv
here to simplify the setup and make the test more robust, but that requires having access totesting.T
.