Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove legacy-api and no-grpc flags from kopia commands #2859

Closed
wants to merge 4 commits into from
Closed

Remove legacy-api and no-grpc flags from kopia commands #2859

wants to merge 4 commits into from

Conversation

pavannd1
Copy link
Contributor

@pavannd1 pavannd1 commented May 4, 2024

Change Overview

  • Revert the revert of @redgoat650's original commit
  • Update to latest commit on kopia master
  • Fix the connection timeout issue - remove DisableGRPC: true, from server connect options in kando

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • fixes #issue-number

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@pavannd1 pavannd1 requested a review from redgoat650 May 4, 2024 08:25
@infraq infraq added this to In Progress in Kanister May 4, 2024
@pavannd1
Copy link
Contributor Author

pavannd1 commented May 6, 2024

Superseded by #2863

@pavannd1 pavannd1 closed this May 6, 2024
Kanister automation moved this from In Progress to Done May 6, 2024
@pavannd1 pavannd1 deleted the kopia-up-test branch May 6, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@redgoat650 redgoat650 Awaiting requested review from redgoat650

Assignees
No one assigned
Labels
None yet
Projects
Kanister
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@pavannd1