Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support fo softlayer API key in ibmclient #286

Merged
merged 10 commits into from
Sep 13, 2019
Merged

Conversation

depohmel
Copy link
Contributor

Change Overview

ibm introduces a bug IBM/ibmcloud-storage-volume-lib#171
one of workarounds is to specify softlayer api key into client

Pull request type

Please check the type of change your PR introduces:

  • Work in Progress
  • Refactoring (no functional changes, no api changes)
  • Trivial/Minor
  • 🐛 Bugfix
  • Feature
  • Documentation

Issues

  • #XXX

Test Plan

  • Manual
  • 🤖 Unit test
  • E2E

Co-Authored-By: Niraj Tolia <ntolia@kasten.io>
pkg/blockstorage/ibm/client.go Outdated Show resolved Hide resolved
pkg/blockstorage/ibm/client.go Outdated Show resolved Hide resolved
pkg/blockstorage/ibm/client.go Show resolved Hide resolved
pkg/blockstorage/ibm/client.go Show resolved Hide resolved
pkg/blockstorage/ibm/client.go Outdated Show resolved Hide resolved
Ilya Kislenko and others added 2 commits September 12, 2019 17:24
Co-Authored-By: Thomas Manville <tom@kasten.io>
Co-Authored-By: Thomas Manville <tom@kasten.io>
@depohmel depohmel merged commit 5063267 into master Sep 13, 2019
@depohmel depohmel deleted the sl-api-key branch September 13, 2019 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants