S3 assume role support #290
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 11, 2019 17:19
It will be used to signal S3 provider to switch roles before establishing connection.
tdmanv
reviewed
Sep 13, 2019
| if err != nil { | ||
| return nil, errors.Wrap(err, "Failed to get role credentials") | ||
| } | ||
| return &awsCreds{ |
There was a problem hiding this comment.
note: not for this PR, but we should consider using the AWS type credential.Value
hakanmemisoglu
commented
Sep 13, 2019
| @@ -48,9 +49,11 @@ type ObjectStoreProviderSuite struct { | |||
| const ( | |||
| testBucketName = "kio-store-tests" | |||
| testRegionS3 = "us-west-2" | |||
| testRole = "" | |||
There was a problem hiding this comment.
We need to create a role for Kanister test purpose, and make it settable by environment variables.
|
Closing this one in favor of #292 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
Add Kanister to support assuming roles for S3 operations.
Pull request type
Please check the type of change your PR introduces:
Test Plan