Add pod and container name to log context #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SupriyaKasten
force-pushed
the
log-podname-containername
branch
from
94669fa
to
0594313
Compare
tdmanv
reviewed
Sep 15, 2019
tdmanv
reviewed
Sep 17, 2019
pkg/function/restore_data.go
Outdated
| @@ -176,6 +177,10 @@ func (*restoreDataFunc) Exec(ctx context.Context, tp param.TemplateParams, args | |||
| } | |||
| // Validate and get optional arguments | |||
| restorePath, encryptionKey, pod, vols, backupTag, backupID, err := validateAndGetOptArgs(args) | |||
|
|
|||
| if pod != "" { | |||
There was a problem hiding this comment.
doesn't this Function also use pod runner?
There was a problem hiding this comment.
It does, but the pod name set here is different than the one that is generated by pod runner.
There was a problem hiding this comment.
I would either drop this or rename the key since it's getting overwritten anyway
There was a problem hiding this comment.
Use a different key in order to tell apart the 2 pod names?
tdmanv
reviewed
Sep 17, 2019
pkg/function/restore_data_all.go
Outdated
| @@ -128,6 +129,7 @@ func (*restoreDataAllFunc) Exec(ctx context.Context, tp param.TemplateParams, ar | |||
| output := make(map[string]interface{}) | |||
| for _, pod := range pods { | |||
| go func(pod string) { | |||
| ctx = field.Context(ctx, field.PodNameKey, pod) | |||
tdmanv
approved these changes
Sep 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
Add pod name and container name to context in addition to actionset name and phase name
Pull request type
Please check the type of change your PR introduces: