Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup go.mod file #2948

Merged
merged 3 commits into from
Jun 19, 2024
Merged

cleanup go.mod file #2948

merged 3 commits into from
Jun 19, 2024

Conversation

julio-lopez
Copy link
Contributor

@julio-lopez julio-lopez commented Jun 19, 2024 •
edited

Change Overview

Put all direct dependencies in a single require block.
Put all indirect dependencies in a single require block.

go mod tidy

Pull request type

  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor

Test Plan

  • 💪 Manual

Addresses #2653 (comment)

@infraq infraq added this to In Progress in Kanister Jun 19, 2024
PrasadG193
PrasadG193 approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@PrasadG193 PrasadG193 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for doing this.

Kanister automation moved this from In Progress to Reviewer approved Jun 19, 2024
@julio-lopez julio-lopez merged commit ad220cf into master Jun 19, 2024
14 checks passed
@julio-lopez julio-lopez deleted the nit/go-mod branch June 19, 2024 05:36
Kanister automation moved this from Reviewer approved to Done Jun 19, 2024
@github-actions github-actions bot mentioned this pull request Jul 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PrasadG193 PrasadG193 PrasadG193 approved these changes

@plar plar Awaiting requested review from plar

@hairyhum hairyhum Awaiting requested review from hairyhum

Assignees
No one assigned
Labels
None yet
Projects
Kanister
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@julio-lopez @PrasadG193