Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move constants from field package to consts package #297

Merged
merged 1 commit into from
Sep 17, 2019

Conversation

SupriyaKasten
Copy link
Contributor

Change Overview

Move constants from field repo to consts repo

Pull request type

Please check the type of change your PR introduces:

  • Work in Progress
  • Refactoring (no functional changes, no api changes)
  • Trivial/Minor
  • Bugfix
  • Feature
  • Documentation

@julio-lopez julio-lopez changed the title Move constants from field repo to consts repo Move constants from field package to consts package Sep 17, 2019
@julio-lopez
Copy link
Contributor

@SupriyaKasten, I assume you meant package in the PR title. I modified it.

Copy link
Contributor

@julio-lopez julio-lopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this. 🥇

@julio-lopez julio-lopez merged commit 8a6de45 into master Sep 17, 2019
@julio-lopez
Copy link
Contributor

Mmmm, I should have changed the commit subject as well. :(

@SupriyaKasten SupriyaKasten deleted the fields-const branch September 24, 2019 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants