Handle nil context value in field.FromContext() func #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdmanv
approved these changes
Sep 18, 2019
julio-lopez
reviewed
Sep 20, 2019
| @@ -10,8 +10,10 @@ const ctxKey = contextKey(43) | |||
|
|
|||
| // FromContext returns the fields present in ctx if any | |||
| func FromContext(ctx context.Context) Fields { | |||
| if s, ok := ctx.Value(ctxKey).(Fields); ok { | |||
| return s | |||
| if ctx != nil { | |||
There was a problem hiding this comment.
OTOH, this should be handled by the caller. For example, context.WithDeadline() does not accept a nil context.
However, this was not explicitly documented in FromContext from the beginning, and overall this approach is more robust.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
Handle nil context value in field.FromContext() func
Pull request type
Please check the type of change your PR introduces: