Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure VPC and Bluemix are non-nil in IBM config #299

Merged
merged 3 commits into from
Sep 18, 2019
Merged

Ensure VPC and Bluemix are non-nil in IBM config #299

merged 3 commits into from
Sep 18, 2019

Conversation

tdmanv
Copy link
Contributor

@tdmanv tdmanv commented Sep 18, 2019

Change Overview

This is a workaround for IBM/ibmcloud-storage-volume-lib#33

Pull request type

Please check the type of change your PR introduces:

  • Work in Progress
  • Refactoring (no functional changes, no api changes)
  • Trivial/Minor
  • Bugfix
  • Feature
  • Documentation

Issues

  • #XXX

Test Plan

  • Manual
  • Unit test
  • E2E

tdmanv and others added 2 commits September 18, 2019 11:46
@tdmanv
Ensure VPC and Bluemix are non-nil in IBM config
fb24a67
Adding test for oldIBM config secret
413d11e 
refactoring tests to use SL_* creds env vars
adding missing optional, but required api field
@depohmel depohmel merged commit 615f81d into master Sep 18, 2019
@depohmel depohmel deleted the ibm-not-nil-cfg-vpc branch September 18, 2019 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@depohmel depohmel depohmel left review comments

@vkamra vkamra vkamra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tdmanv @vkamra @depohmel