Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle panic in IBM initialization #301

Merged
merged 2 commits into from
Sep 19, 2019
Merged

Handle panic in IBM initialization #301

merged 2 commits into from
Sep 19, 2019

Conversation

tdmanv
Copy link
Contributor

@tdmanv tdmanv commented Sep 18, 2019

Change Overview

This wraps the IBM client initialization and will return an error instead of panicking.

Pull request type

Please check the type of change your PR introduces:

  • Work in Progress
  • Refactoring (no functional changes, no api changes)
  • Trivial/Minor
  • Bugfix
  • Feature
  • Documentation

Issues

Test Plan

[14:56:24]tom@tom-XPS-13-9360: (master)~/src/kanister/ go test -v ./pkg/blockstorage/ibm -check.v -check.f TestPanic
=== RUN   Test
PASS: client_test.go:134: ClientSuite.TestPanic 0.000s
OK: 1 passed
--- PASS: Test (0.00s)
PASS
ok      github.com/kanisterio/kanister/pkg/blockstorage/ibm     0.008s
  • Manual
  • Unit test
  • E2E

@tdmanv tdmanv merged commit 4bf0e2d into master Sep 19, 2019
@tdmanv tdmanv deleted the handle-ibm-panic branch September 19, 2019 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@depohmel depohmel depohmel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tdmanv @depohmel