Add PodOverride field to Actionset that will override the default podSpec #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SupriyaKasten
force-pushed
the
podoverride-actionsetspec
branch
2 times, most recently
from
e26308d
to
b5bdc4d
Compare
tdmanv
reviewed
Sep 23, 2019
pkg/apis/cr/v1alpha1/types.go
Outdated
| @@ -98,6 +99,9 @@ type ActionSpec struct { | |||
| // Profile is use to specify the location where store artifacts and the | |||
| // credentials authorized to access them. | |||
| Profile *ObjectReference `json:"profile"` | |||
| // PodOverride is use to specify pod specs that will override the | |||
| // default pod specs | |||
| PodOverride v1.PodSpec `json:"podOverride"` | |||
There was a problem hiding this comment.
Let's add the omitEmpty tag here
There was a problem hiding this comment.
Makes sense, added this change!
tdmanv
approved these changes
Sep 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
Add PodOverride field to Actionset that will override the default podSpec. This will help us to resolve the issue #289
Pull request type
Please check the type of change your PR introduces:
Issues