Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add E2E test for custom labels/annotations to function pods #3053

Merged
merged 6 commits into from
Aug 26, 2024

Conversation

viveksinghggits
Copy link
Contributor

@viveksinghggits viveksinghggits commented Aug 21, 2024

Change Overview

This PR adds e2e test to verify that the labels and annotations configured via the actionset and blueprint are properly added to the pod that is created via the kanister functions run by an actionset.

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test
  • 🏗️ Build

Issues

  • fixes #issue-number

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E
make test
ller).onUpdateActionSet","Line":256,"hostname":"orbstack","level":"info","msg":"Updated ActionSet 'actionset-lkznq' Status-\u003ecomplete","time":"2024-08-22T14:22:06.417586158Z"}
PASS: e2e_test.go:300: E2ESuite.TestPodLabelsAndAnnotations     95.080s
OK: 1 passed
--- PASS: Test (96.73s)
PASS
ok      github.com/kanisterio/kanister/pkg/testing      96.885s
=== RUN   Test
OK: 0 passed
--- PASS: Test (0.00s)
PASS
ok      github.com/kanisterio/kanister/pkg/testing/helm 0.090s

PASS

real 117.83
user 0.00
sys 0.00

Base automatically changed from label-ann-actionset to master August 26, 2024 10:25
@mergify mergify bot merged commit 4440289 into master Aug 26, 2024
18 checks passed
@mergify mergify bot deleted the e2e-pod-lables-ann branch August 26, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants