Add support for overriding default pod specs #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrasadG193
changed the title
PrasadG193
force-pushed
the
pod-spec-override
branch
2 times, most recently
from
603e357
to
81296b7
Compare
Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
PrasadG193
force-pushed
the
pod-spec-override
branch
from
81296b7
to
633233f
Compare
Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
tdmanv
reviewed
Sep 24, 2019
| ServiceAccountName: opts.ServiceAccountName, | ||
| } | ||
| // Override default specs if podspecs are passed | ||
| if !reflect.DeepEqual(opts.PodOverride, v1.PodSpec{}) { |
There was a problem hiding this comment.
rather than repeat this check in each function, can we push this logic down into PodSpecOverride?
SupriyaKasten
approved these changes
Sep 24, 2019
|
Merging this PR, we can work on the review requests in a new PR. |
julio-lopez
reviewed
Sep 24, 2019
| @@ -133,3 +151,18 @@ func WaitForPodCompletion(ctx context.Context, cli kubernetes.Interface, namespa | |||
| }) | |||
| return errors.Wrap(err, "Pod did not transition into complete state") | |||
| } | |||
|
|
|||
| // PodSpecOverride override default pod Spec with the ones provided via specs | |||
| func PodSpecOverride(ctx context.Context, defaultSpecs, overrideSpecs v1.PodSpec) (v1.PodSpec, error) { | |||
There was a problem hiding this comment.
- I am confused about what the semantics (expected behavior) for this function are. It is not clear from the documentation.
- From whatever I can infer (really guess), it is not clear that the implementation below achieves that.
- Is there test coverage for this function?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
This PR adds support for overriding default pod specs using blueprint args and actionset fields
Usage:
Pod spec overriding with Blueprint args:
- func: PrepareData name: dumpToObjectStore args: podOverride: containers: - command: ["ls", "-l", "/override"]Pod spec overriding with Actionset fields:
spec: actions: podOverride: containers: - imagePullPolicy: Never volumeMounts: - mountPath: /override name: data volumes: - name: data persistentVolumeClaim: claimName: my-release-mysqlPull request type
Please check the type of change your PR introduces:
Issues
Test Plan