Update getOSSecret to use Secret credentials in AWS #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks good to me @hakanmemisoglu will let @pavannd1 or @tdmanv accept the PR. |
pavannd1
reviewed
Sep 20, 2019
pkg/testutil/fixture.go
Outdated
| @@ -40,8 +41,12 @@ func ObjectStoreProfileOrSkip(c *check.C, osType objectstore.ProviderType, locat | |||
|
|
|||
| switch osType { | |||
| case objectstore.ProviderTypeS3: | |||
| session, ok := os.LookupEnv(awsconfig.SessionToken) | |||
There was a problem hiding this comment.
[minor] Move this below key, val and can be inlined I think
pavannd1
reviewed
Sep 20, 2019
pavannd1
approved these changes
Sep 20, 2019
hakanmemisoglu
pushed a commit
that referenced
this pull request
Sep 20, 2019
This reverts commit 2192605.
mergify bot
pushed a commit
that referenced
this pull request
Sep 20, 2019
* Revert "Update getOSSecret to use Secret credentials in AWS (#309)" This reverts commit 2192605. * Revert "Add secret type credential to validation code (#308)" This reverts commit 9178d4c. * Revert "Support creating S3 args from Secret type Credential (#305)" This reverts commit d8f7d76. * Revert "Add secret type for Param.Credentials (#300)" This reverts commit ad3cbce.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
Support secret credential type in S3.
Pull request type
Please check the type of change your PR introduces: