Replace import sirupsen/logrus by pkg/log #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SupriyaKasten
force-pushed
the
export-log
branch
from
d97c470
to
a38a13a
Compare
|
cool! |
tdmanv
reviewed
Oct 16, 2019
pkg/blockstorage/awsebs/awsebs.go
Outdated
| @@ -522,7 +523,7 @@ func waitOnVolume(ctx context.Context, ec2Cli *EC2, vol *ec2.Volume) error { | |||
| for { | |||
| dvo, err := ec2Cli.DescribeVolumesWithContext(ctx, dvi) | |||
| if err != nil { | |||
| log.Errorf("Failed to describe volume %s Error: %+v", aws.StringValue(vol.VolumeId), err) | |||
| log.WithError(err).Print(fmt.Sprintf("Failed to describe volume %s", aws.StringValue(vol.VolumeId))) | |||
There was a problem hiding this comment.
please avoid using fmt.Sprintf when logging
Co-Authored-By: Thomas Manville <tom@kasten.io>
Co-Authored-By: Thomas Manville <tom@kasten.io>
SupriyaKasten
force-pushed
the
export-log
branch
from
0cfdb6d
to
618a1d9
Compare
tdmanv
reviewed
Oct 17, 2019
| @@ -165,7 +167,8 @@ func (c *Controller) onUpdate(oldObj, newObj interface{}) { | |||
| c.logAndErrorEvent(nil, "Callback onUpdateBlueprint() failed:", "Error", err, new) | |||
| } | |||
| default: | |||
| log.Errorf("Unknown object type <%T>", oldObj) | |||
| objType := fmt.Sprintf("%T", oldObj) | |||
There was a problem hiding this comment.
FYI we can just pass in the object directly. this is fine by me though
tdmanv
reviewed
Oct 17, 2019
Co-Authored-By: Thomas Manville <tom@kasten.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
Replace import sirupsen/logrus by pkg/log
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan