Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamically update Kanister version in docs #327

Merged
merged 2 commits into from
Oct 1, 2019
Merged

Conversation

ntolia
Copy link
Contributor

@ntolia ntolia commented Sep 30, 2019

Change Overview

  • This assumes that docs are generated and published after the release
  • This also removes the docs package from the bump_version script

Pull request type

Please check the type of change your PR introduces:

  • Work in Progress
  • Refactoring (no functional changes, no api changes)
  • Trivial/Minor
  • Bugfix
  • Feature
  • Documentation

Test Plan

  • Manual
  • Unit test
  • E2E

- This assumes that docs are generated and published after the release
- This also removes the docs package from the bump_version script
made it simple to add these tools to your container.

The released image, `kanisterio/kanister-tools:0.21.0`, is hosted by
The released image, `kanisterio/kanister-tools`, is hosted by
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The released image, `kanisterio/kanister-tools`, is hosted by
The released image, `kanisterio/kanister-tools:|version|`, is hosted by

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, this isn't rendering. I will look into why but likely because anything within quotes here is not interpreted. Another change I have coming up will help.

@SupriyaKasten
Copy link
Contributor

Looks good to me!

@mergify mergify bot merged commit 5fb0a85 into master Oct 1, 2019
@mergify mergify bot deleted the release_version branch October 1, 2019 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants